Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: No Scrolling Required for Some TLDR Descriptions Due to Short Length #1318

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

MuhammadUmer44
Copy link
Contributor

@MuhammadUmer44 MuhammadUmer44 commented Apr 22, 2024

Problem:

  • Certain TLDR descriptions do not require scrolling because they are short and do not extend beyond the visible area. However, the scrolling functionality is still enabled, leading to unnecessary user interaction and potentially affecting the user experience.

Expected Behavior:

  • Verify that scrolling is automatically hidden for TLDR descriptions that are shorter than the visible area of the screen.
  • Ensure that scrolling functionality is only enabled for TLDR descriptions that exceed the visible area, preventing unnecessary user interaction.

closes: #1287

Issue ticket number and link:

Evidence:

@MuhammadUmer44
Copy link
Contributor Author

Hi @Rassl,
Please review this PR.

@Rassl
Copy link
Collaborator

Rassl commented Apr 23, 2024

@MuhammadUmer44 fix conflicts please

@MuhammadUmer44
Copy link
Contributor Author

@Rassl, Ok i fix it and ping you.

@MuhammadUmer44
Copy link
Contributor Author

@MuhammadUmer44 fix conflicts please

Done

@Rassl
Copy link
Collaborator

Rassl commented Apr 24, 2024

@MuhammadUmer44 I don't see any reason to use js calculation for this, it should be pure css fix, or not a bug at all.

@MuhammadUmer44
Copy link
Contributor Author

@MuhammadUmer44
Copy link
Contributor Author

Hi @Rassl,
Please see the new fixed code result in the video at:
https://www.loom.com/share/fe4f7367378a494a9783fa2d2d01fe10

@MuhammadUmer44
Copy link
Contributor Author

Hi @Rassl,
Please review this PR.

Copy link
Collaborator

@Rassl Rassl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rassl Rassl merged commit 1f7f9fb into stakwork:master Apr 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Scrolling Required for Some TLDR Descriptions Due to Short Length
2 participants