-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete node on the frontend should remove it from the graph #1311
Delete node on the frontend should remove it from the graph #1311
Conversation
@tomsmith8 @Rassl Kindly review this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look to my comment
@Rassl Here, we are simply deleting the selected node from the data store so that it is reflected throughout the entire app. Therefore, the ref_id must match in order to remove the selected node from the graph. At previous case: |
not sure what are you trying to explain here, the only problem in current changes is this lines, for node type |
You are right but when the actual id pass to the removeNode function then at that function the actual ref_id is not match with the fake node type ref_id that is present in data of type NodeExtended |
@Rassl Please review the changes now. You are right to delete a node from backend we need to pass actual id that would be come from topic node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket №: #1264
closes #1264
Problem:
Delete node on the frontend should remove it from the graph
As a Proof:
https://www.loom.com/share/a7560e9de6cb4502a5beb2a3af78390e?sid=0dae9776-94fb-4fb1-b367-c67ea076bfd3