Merge pull request #1277 from stakwork/hotfix/schema-filter-invalid

fix: filter out invalid schema options
stakwork · Apr 17, 2024 · 68d693e · 68d693e
2 parents 93905f5 + be57974
commit 68d693e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/components/AddItemModal/SourceTypeStep/__tests__/index.tsx b/src/components/AddItemModal/SourceTypeStep/__tests__/index.tsx
@@ -40,10 +40,10 @@ describe('SourceTypeStep', () => {
 
   it('should filter out deleted node types', async () => {
     const mockedSchemaTypes = [
-      { type: 'node1', is_deleted: false },
+      { type: 'node1', is_deleted: false, ref_id: 'refId1' },
       { type: 'node2', is_deleted: true },
-      { type: 'about', is_deleted: false },
-      { type: 'schema', is_deleted: false },
+      { type: 'about', is_deleted: false, ref_id: 'refId2' },
+      { type: 'schema', is_deleted: false, ref_id: 'refId3' },
     ]
 
     jest.spyOn(fetchSourcesData, 'getNodeSchemaTypes').mockResolvedValue({ schemas: mockedSchemaTypes })

diff --git a/src/components/AddItemModal/SourceTypeStep/index.tsx b/src/components/AddItemModal/SourceTypeStep/index.tsx
@@ -26,7 +26,7 @@ export const SourceTypeStep: FC<Props> = ({ skipToStep, allowNextStep, onSelectT
           const nodeTypesToHide = ['about', 'schema']
 
           const schemaOptions = data.schemas
-            .filter((schema) => !nodeTypesToHide.includes(schema.type) && !schema.is_deleted)
+            .filter((schema) => schema.ref_id && !nodeTypesToHide.includes(schema.type) && !schema.is_deleted)
             .map((schema) => ({
               label: capitalizeString(schema.type),
               value: schema.type,

diff --git a/src/components/SettingsModal/SettingsView/GraphBlueprint/index.tsx b/src/components/SettingsModal/SettingsView/GraphBlueprint/index.tsx
@@ -17,7 +17,7 @@ export const GraphBlueprint: React.FC = () => {
       try {
         const response = await getSchemaAll()
 
-        setSchemaAll(response.schemas.filter((i) => !i.is_deleted))
+        setSchemaAll(response.schemas.filter((i) => i.ref_id && !i.is_deleted))
 
         setLoading(false)
       } catch (error) {