Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INFRA-839 Add playbooks, config & docs for enabling Pulp tls with vault #1427

Open
wants to merge 2 commits into
base: stackhpc/2024.1
Choose a base branch
from

Conversation

technowhizz
Copy link
Contributor

No description provided.

@technowhizz technowhizz self-assigned this Dec 13, 2024
@technowhizz technowhizz requested a review from a team as a code owner December 13, 2024 10:14
@product-auto-label product-auto-label bot added size: m ansible Ansible playbooks labels Dec 13, 2024
Add playbooks, config & docs for enabling pulp tls with vault
@technowhizz technowhizz force-pushed the update-vault-docs-dec-2024 branch from 0281769 to b69f2bd Compare December 13, 2024 10:36
@technowhizz technowhizz changed the title Add playbooks, config & docs for enabling Pulp tls with vault INFRA-839 Add playbooks, config & docs for enabling Pulp tls with vault Dec 13, 2024
Dont start bifrost playbooks when deploying pulp tls

Co-authored-by: Matt Crees <[email protected]>
hosts: controllers
run_once: true
vars:
vault_api_addr: "https://{{ internal_net_name | net_ip(groups['controllers'][0]) }}:8200"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing to point out here is that we have a bootstrapping issue where we have to bring the controllers up and deploy vault before generating the certs. You could use the vault on the seed to generate the certificate for pulp instead, but is it better to always use the overcloud vault? What do people think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to use vault from the seed (which might make more sense, since this is being deployed on the seed) then we'll need a second intermediate CA?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to have TLS for Pulp before we need to use Pulp at all, so even before Bifrost. So +1 to not relying on the overcloud vault

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do that as a part 2? and perhaps call this 'Deploying pulp with TLS on an existing cloud?'

seunghun1ee
seunghun1ee previously approved these changes Dec 17, 2024
Copy link
Member

@seunghun1ee seunghun1ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we also need to add the cert to the docker config directory? /etc/docker/certs/ I think.
If we can restart docker, this is not needed though.

@seunghun1ee seunghun1ee dismissed their stale review December 17, 2024 11:45

Approval by mistake

@technowhizz
Copy link
Contributor Author

Don't we also need to add the cert to the docker config directory? /etc/docker/certs/ I think. If we can restart docker, this is not needed though.

Yeah, so I think docker will use the system CA trust but you might be right about needing to restart docker for that. Also if we did need to add the CA cert to docker I realised @seunghun1ee that we have a variable in kayobe for that

#docker_registry_ca:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible playbooks size: m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants