Provide support for ssh-sk for Nova
#1386
Draft
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
reviewed
Nov 26, 2024
etc/kayobe/kolla.yml
Outdated
| @@ -346,6 +346,11 @@ kolla_build_blocks: | |||
| {% set magnum_capi_packages = ['magnum-capi-helm==1.1.0'] %} | |||
| RUN {{ macros.install_pip(magnum_capi_packages | customizable("pip_packages")) }} | |||
| {% endraw %} | |||
| nova_base_footer: | | |||
| {% raw %} | |||
| {% set nova_packages = ['cryptography==43.0.0'] %} | |||
There was a problem hiding this comment.
I assume cryptography is pulled in as a dependency to Nova? Just bump it up in upper-constraints using a macro?
There was a problem hiding this comment.
I wasn't sure what the best approach is as adjusting upper-constraints would impact more than just Nova.
There was a problem hiding this comment.
Well, we use u-c fork as a repo, but there are macros in Kolla that mangle u-c entries - you could use that only for Nova.
jackhodgkiss
force-pushed
the
add-sk-support-for-nova
branch
3 times, most recently
from
62c4d6e to
d335906
Compare
Support for `ssh-sk` keys was recently added in the cryptography package pyca/cryptography#10608. By installing version `43.0.0` we can benefit from such support within `Nova`
The `Nova` containers with the tag `20241126T110410` provides support for `ssh-sk` providing users the option of improving the security of SSH access to their instances. [skip ci]
jackhodgkiss
force-pushed
the
add-sk-support-for-nova
branch
from
d335906 to
810c48f
Compare
mnasiadka
approved these changes
Nov 28, 2024
|
@mnasiadka not sure why it is failing to build. I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide
ssh-skbased keys for use withinNovaproviding users with the ability to further secureSSHaccess to their instances.This has been achieved with by bumping the
cryptographypackage to version43.0.0which includes pyca/cryptography#10608.