INFRA-388 Converting smartmon into python and adding mock tests #1327
+421
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougszumski
reviewed
Oct 25, 2024
| def parse_smartctl_attributes(disk, disk_type, serial, json_data): | ||
| labels = f'disk="{disk}",type="{disk_type}",serial_number="{serial}"' | ||
| metrics = [] | ||
| smartmon_attrs = set([ |
There was a problem hiding this comment.
style nit: It would be helpful to move these to a 'constant' eg. SMARTMON_ATTRS = set(.. and put each attribute on a new line.
| try: | ||
| version_output = run_command([SMARTCTL_PATH, '-j'], parse_json=True) | ||
| smartctl_version_list = version_output.get('smartctl', {}).get('version', []) | ||
| if smartctl_version_list: |
There was a problem hiding this comment.
Have you looked at Python libraries for doing this?
Eg. This one looks reasonable: https://pypi.org/project/pySMART/
It can handle loading all the device metrics in via smartctl as you are doing here.
It seems to provide some abstraction over the health state as well.
The work you've put into the tests should be directly usable
| class TestSmartMon(unittest.TestCase): | ||
| @patch('smartmon.run_command') | ||
| def test_parse_smartctl_info(self, mock_run_command): | ||
| devices_info = [ |
There was a problem hiding this comment.
It would be useful to factor this example data out into a dedicated file. Then we can have a file for each HW profile, and loop over them.
Alex-Welsh
added
stackhpc-ci
Alex-Welsh
added
enhancement
technowhizz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.