fix: conditional error when no seed exists #1038
Conversation
In situations where there is no `seed` the `seed-hypervisor` will fail a host configure against `no_proxy` settings due to the conditional attempting to access attributes that do not exist.
jackhodgkiss
force-pushed
the
fix-seed-hypervisor-proxy
branch
from
2cd2130 to
62fc1e7
Compare
| # The default value whilst only applied if `http_proxy` and `https_proxy` are set | ||
| # will not work as the conditional fails to evaluate if the seed node does not exist. | ||
| # This makes the `seed-hypervisor` reliant on the seed node. | ||
| no_proxy: [] |
There was a problem hiding this comment.
I'm not sure how this would help. The walled garden docs only mention setting no_proxy for hosts in the overcloud group.
There was a problem hiding this comment.
The problem is no_proxy still needs to evaluated for the conditional which means attempting to expand the default value for which it cannot due to the lack of the seed-vm at the time of creating a seed-hypervisor.
There was a problem hiding this comment.
Ah, ok. Kayobe default for no_proxy is:
no_proxy:
- "127.0.0.1"
- "localhost"
- "{{ ('http://' ~ docker_registry) | urlsplit('hostname') if docker_registry else '' }}"
So this comes from docker_registry -> stackhpc_docker_registry -> pulp_url -> groups.seed.0.
So I think we should either make pulp_url conditional on groups.seed | length > 0, or document the change you've made in this PR in the walled garden guide. We don't have any other walled garden config in by default, so I don't think it makes sense to add this.
There was a problem hiding this comment.
I will look at making pulp_url conditional. Thanks.
|
@jackhodgkiss any updates on this? |
Alex-Welsh
added
bug
In situations where there is no
seedtheseed-hypervisorwill fail a host configure againstno_proxysettings due to the conditional attempting to access attributes that do not exist.