Add more information re. configuring production sites #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sd109
approved these changes
Dec 20, 2024
| - `staging`: staging environment | ||
|
|
||
| A `dev` environment should also be created if considered required, or this | ||
| can be left till later., |
There was a problem hiding this comment.
Nit:
Suggested change
| can be left till later., | |
| can be left until later., |
Comment on lines
+67
to
+72
| - Vault-encrypt secrets. Running the `generate-passwords.yml` playbook creates | ||
| a secrets file at `environments/$ENV/inventory/group_vars/all/secrets.yml`. | ||
| To ensure staging environments are a good model for production this should | ||
| generally be moved into the `site` environment. It should be be encrypted | ||
| using [Ansible vault](https://docs.ansible.com/ansible/latest/user_guide/vault.html) | ||
| and then committed to the repository. |
There was a problem hiding this comment.
Does this mean that the same secrets are used for staging and production? Maybe it would be better to recommend generating different secrets for each env?
| instances) it may be necessary to configure or proxy `chronyd` via an | ||
| environment hook. | ||
|
|
||
| - The cookiecutter provided tofu configurations define resources for home and |
There was a problem hiding this comment.
Nit: We should probably use OpenTofu everywhere instead of just tofu
Suggested change
| - The cookiecutter provided tofu configurations define resources for home and | |
| - The cookiecutter provided OpenTofu configurations define resources for home and |
Comment on lines
+83
to
+84
| the volumes should be manually created and the resources changed to data | ||
| resources. This ensures that even if the cluster is deleted via tofu, the |
There was a problem hiding this comment.
Suggested change
| the volumes should be manually created and the resources changed to data | |
| resources. This ensures that even if the cluster is deleted via tofu, the | |
| the volumes should be manually created and the resources changed to [data | |
| resources](https://opentofu.org/docs/language/data-sources/). This ensures that even if the cluster is deleted via tofu, the |
|
|
||
| Note the variable `control_ip_address` is new. | ||
|
|
||
| Using fixed IPs will require either using admin credentials or policy changes. |
There was a problem hiding this comment.
In Azimuth we handle this by saying you have to pre-allocate the FIP to the project manually (i.e. openstack floating ip create <network>) and then put the allocated FIP into the config. Maybe we could do the same here and make control_ip_address a data resource instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.