Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mapping to compute + login to ironic nodes #485

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Nov 20, 2024

Add support to non-caas environments for mapping baremetal compute and/or login nodes to ironic hosts with the same names, e.g:

# environments/$env/terraform/terraform.tfvars:
...
cluster_name = "mycloud"
login_nodes = {
    login-0 = {
        flavor: "baremetal.highmem"
        match_ironic_node: true
    }
}
compute = {
    hpc = {
        flavor = "baremetal.xlarge"
        match_ironic_node: true
        nodes = ["hpc-0", "hpc-1", "hpc-2"]
    }
}
...

will result in an instance named mycloud-login-0 on ironic node login-0, and compute instances mycloud-hpc-N on ironic nodes hpc-N.

NB: To support this the definition of login nodes has changed slightly.

Also fixes a reversion where with the tf variable volume_backed_instances set, compute nodes were not actually volume-backed.

Note this PR only affects new environments, unless changes from skeleton terraform are copied over to site-specific environments.

Tests:

  • Works for non-mapped nodes on a cloud where user does not have support for listing baremetal nodes
  • Works for mapping nodes on a cloud where user does have support for listing baremetal nodes
  • Can create an entire volume-backed cluster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants