Defaults from common and cookiecutter now give working appliance #473
Conversation
wtripp180901
commented
Nov 11, 2024
wtripp180901
commented
- Enables etc_hosts by default for working internal DNS
- OpenOndemand now has working set of default variables
- Creates default user to access OOD with
- Default cluster suffix is now "internal" instead of "invalid"
| basic_users_homedir: /home | ||
| basic_users_users: [] | ||
| basic_users_users: |
There was a problem hiding this comment.
I don't think I like defining this here. This means any site which has basic_users enabled will suddenly get this new user which they didn't know they had ...
I think defining the password in the secrets is maybe OK, but could you look at whether e.g we can provide a basic_users.yml file with this in via cookiecutter? That would mean only new environments get the user added.
| basic_users_homedir: /home | ||
| basic_users_users: [] | ||
| basic_users_users: | ||
| - name: ood_user |
There was a problem hiding this comment.
Don't like this name, it's not just for OOD. I would call it "demo_user" I think, makes it clear its not supposed to be for production. And the stackhpc environment should be modified to use this too, rather than the current test user.
| @@ -3,5 +3,10 @@ | |||
| # See: ansible/roles/basic_users/README.md | |||
| # for variable definitions. | |||
|
|
|||
| ondemand_user_password: "{{ vault_openondemand_default_user_password }}" | |||
There was a problem hiding this comment.
Don't need this indirection here really.
|
|
||
| openondemand_auth: basic_pam | ||
|
|
||
| openondemand_jupyter_partition: "{{ openhpc_slurm_partitions[0]['name'] }}" |
There was a problem hiding this comment.
Does this work OK for ordering? E.g. if you try
ansible all -m debug -a var=openondemand_jupyter_partition does it work, or does it complain something is undefined? I have a memory of the lexicographical ordering of openondemand.yml vs openhpc.yml being important here.
|
@wtripp180901 when you get back to this pls can you update docs/production.md too? |
