Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating tofu-controlled compute volumes #452

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Oct 15, 2024

Adds "volumes" key to compute module to define optional tofu-controlled volumes attached to compute nodes. Useful for simulating additional disks present in baremetal instances using virtualized instances.

TODO: test that, at least with no volumes actually defined, changing the image results in a "update" (i.e. rebuild) not delete/recreate.
A delete/recreate is acceptable when:

  • Changing to this TF for the first time
  • Updating the image on a compute node with attached volumes (although it'd be nice to test/know whether it will do that)
  • Adding volumes to a compute node which doesn't have them (will definitely be delete/recreate, no need to test)

@sjpb sjpb changed the title allow creating tofu-controlled compute volumes Allow creating tofu-controlled compute volumes Oct 15, 2024
@wtripp180901
Copy link
Contributor

Warning: updating images for compute nodes currently forces them to be destroyed and replaced as the uuid of their block devices changes, even if no volumes are defined for them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants