Override bootstrap host assuming mon[0] is available #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For case where mon[0] is being rebuilt we can't direct the bootstrap requests there.
For the case where we are rebuilding mon[0] we need to direct commands to another host
markgoddard
suggested changes
Jul 4, 2023
| @@ -8,5 +8,5 @@ | |||
| changed_when: true | |||
| when: cephadm_commands | length > 0 | |||
|
|
|||
| delegate_to: "{{ groups['mons'][0] }}" | |||
| delegate_to: "{{ cephadm_bootstrap_host }}" | |||
There was a problem hiding this comment.
Each of these roles will need a default for this variable.
I wonder how appropriate the name is, since these roles will execute after bootstrap is complete. How about cephadm_delegate_host?
|
That makes sense to me too
From: Mark Goddard ***@***.***>
Date: Tuesday, 4 July 2023 at 09:03
To: stackhpc/ansible-collection-cephadm ***@***.***>
Cc: Stuart Cornell ***@***.***>, Author ***@***.***>
Subject: Re: [stackhpc/ansible-collection-cephadm] Override bootstrap host assuming mon[0] is available (PR #109)
@markgoddard requested changes on this pull request.
________________________________
In roles/commands/tasks/main.yml<#109 (comment)>:
@@ -8,5 +8,5 @@
changed_when: true
when: cephadm_commands | length > 0
- delegate_to: "{{ groups['mons'][0] }}"
+ delegate_to: "{{ cephadm_bootstrap_host }}"
Each of these roles will need a default for this variable.
I wonder how appropriate the name is, since these roles will execute after bootstrap is complete. How about cephadm_delegate_host?
—
Reply to this email directly, view it on GitHub<#109 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMSV7WA2OF4BNTG4MBYZ2LDXOPE5NANCNFSM6AAAAAAZ4Q7JSY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
** We have updated our privacy policy, which contains important information about how we collect and process your personal data. To read the policy, please click here<http://www.graphcore.ai/privacy> **
This email and its attachments are intended solely for the addressed recipients and may contain confidential or legally privileged information.
If you are not the intended recipient you must not copy, distribute or disseminate this email in any way; to do so may be unlawful.
Any personal data/special category personal data herein are processed in accordance with UK data protection legislation.
All associated feasible security measures are in place. Further details are available from the Privacy Notice on the website and/or from the Company.
Graphcore Limited (registered in England and Wales with registration number 10185006) is registered at 107 Cheapside, London, UK, EC2V 6DN.
This message was scanned for viruses upon transmission. However Graphcore accepts no liability for any such transmission.
|
|
Some kayobe playbooks I have been working benefits from on PR such as this. Something such as delegate_to: "{{ lookup('vars', admin_oc_net_name ~ '_ips')[cephadm_delegate_host | default(groups['mons'][0], true)] }}"Would allow for overriding the delegate host when needed and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rebuilding mon[0] we need to use a different bootstrap hosts, however many rules have mon[0] hard-coded