Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Move gracefulShutdownTimeout to roleGroup config #486

Merged
merged 25 commits into from
Nov 7, 2023

doc review

41596a4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

refactor!: Move gracefulShutdownTimeout to roleGroup config #486

doc review
41596a4
Select commit
Loading
Failed to load commit list.
GitHub Actions / LanguageTool completed Nov 7, 2023 in 1s

reviewdog [LanguageTool] report

reported by reviewdog 🐶

Findings (1)

docs/modules/trino/pages/usage-guide/operations/graceful-shutdown.adoc|51 col 360| A comma may be missing after the conjunctive/linking adverb ‘Currently’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: Currently,
URL: https://languagetool.org/insights/post/linking-words/
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION

Filtered Findings (39)

.github/pull_request_template.md|16 col 36| This expression is normally spelled as one or with a hyphen. (EN_COMPOUNDS)
Suggestions: non-trivial, nontrivial
URL: https://languagetool.org/insights/post/hyphen/
Rule: https://community.languagetool.org/rule/show/EN_COMPOUNDS?lang=en-US
Category: MISC
CHANGELOG.md|55 col 72| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 1 GB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
CHANGELOG.md|55 col 133| A comma may be missing after the conjunctive/linking adverb ‘Instead’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: Instead,
URL: https://languagetool.org/insights/post/linking-words/
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION
CHANGELOG.md|292 col 47| Make sure that ‘anymore’ is used as an adverb, not as an adjective. Did you mean “any more”? (ANYMORE_ADVERB[1])
Suggestions: any more
URL: https://www.grammarphobia.com/blog/2011/04/anymore-3.html
Rule: https://community.languagetool.org/rule/show/ANYMORE_ADVERB?lang=en-US&subId=1
Category: GRAMMAR
README.md|61 col 19| It appears that hyphens are missing in the adjective “up-to-date”. (UP_TO_DATE_HYPHEN[2])
Suggestions: up-to-date
URL: https://languagetool.org/insights/post/hyphen/#hyphenated-phrases-with-more-than-one-hyphen
Rule: https://community.languagetool.org/rule/show/UP_TO_DATE_HYPHEN?lang=en-US&subId=2
Category: COMPOUNDING
docs/modules/trino/pages/getting_started/first_steps.adoc|3 col 180| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/trino/pages/getting_started/first_steps.adoc|44 col 45| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 5 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/getting_started/first_steps.adoc|45 col 45| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 5 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/getting_started/index.adoc|17 col 2| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 256 MB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/catalogs/generic.adoc|3 col 43| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/grammar-what-are-compound-sentences/
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/catalogs/generic.adoc|52 col 17| Use “a” instead of ‘an’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN)
Suggestions: a
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
docs/modules/trino/pages/usage-guide/catalogs/google-sheets.adoc|23 col 36| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 5 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/catalogs/google-sheets.adoc|23 col 63| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 5 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/catalogs/hive.adoc|100 col 6| File types are normally capitalized. (FILE_EXTENSIONS_CASE[1])
Suggestions: XML
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en-US&subId=1
Category: CASING
docs/modules/trino/pages/usage-guide/catalogs/hive.adoc|109 col 6| File types are normally capitalized. (FILE_EXTENSIONS_CASE[1])
Suggestions: XML
URL: https://languagetool.org/insights/post/spelling-capital-letters/
Rule: https://community.languagetool.org/rule/show/FILE_EXTENSIONS_CASE?lang=en-US&subId=1
Category: CASING
docs/modules/trino/pages/usage-guide/catalogs/iceberg.adoc|18 col 41| Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’. (EN_A_VS_AN)
Suggestions: an
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
docs/modules/trino/pages/usage-guide/catalogs/index.adoc|6 col 9| Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Suggestions: catalogs
Rule: https://community.languagetool.org/rule/show/ENGLISH_WORD_REPEAT_RULE?lang=en-US
Category: MISC
docs/modules/trino/pages/usage-guide/catalogs/index.adoc|90 col 43| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/grammar-what-are-compound-sentences/
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|28 col 38| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 2 GB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|38 col 34| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 2 GB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|137 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 3350 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|138 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 11700 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|139 col 3| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 12704 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|151 col 16| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 500 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|152 col 16| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 2000 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|162 col 16| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 1000 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/configuration.adoc|163 col 16| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 4000 m
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/connect_to_trino.adoc|3 col 33| Use “an” instead of ‘a’ if the following word starts with a vowel sound, e.g. ‘an article’, ‘an hour’. (EN_A_VS_AN)
Suggestions: an
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
docs/modules/trino/pages/usage-guide/connect_to_trino.adoc|3 col 45| Use “A” instead of ‘An’ if the following word doesn’t start with a vowel sound, e.g. ‘a sentence’, ‘a university’. (EN_A_VS_AN)
Suggestions: A
URL: https://languagetool.org/insights/post/indefinite-articles/
Rule: https://community.languagetool.org/rule/show/EN_A_VS_AN?lang=en-US
Category: MISC
docs/modules/trino/pages/usage-guide/connect_to_trino.adoc|31 col 1| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/trino/pages/usage-guide/connect_to_trino.adoc|37 col 82| A comma may be missing after the conjunctive/linking adverb ‘Additionally’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: Additionally,
URL: https://languagetool.org/insights/post/linking-words/
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/connect_to_trino.adoc|38 col 129| In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects. (AFTERWARDS_US[1])
Suggestions: Afterward
Rule: https://community.languagetool.org/rule/show/AFTERWARDS_US?lang=en-US&subId=1
Category: BRITISH_ENGLISH
docs/modules/trino/pages/usage-guide/operations/pod-placement.adoc|9 col 1| A comma may be missing after the conjunctive/linking adverb ‘Additionally’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: Additionally,
URL: https://languagetool.org/insights/post/linking-words/
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/query.adoc|8 col 33| If a new sentence starts here, add a space and start with an uppercase letter. (LC_AFTER_PERIOD[1])
Suggestions: Iris, iris
Rule: https://community.languagetool.org/rule/show/LC_AFTER_PERIOD?lang=en-US&subId=1
Category: CASING
docs/modules/trino/pages/usage-guide/query.adoc|65 col 36| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 11.3 KB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/query.adoc|66 col 41| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 3.02 KB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/query.adoc|69 col 15| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 8.08 KB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
docs/modules/trino/pages/usage-guide/query.adoc|69 col 34| Insert a space between the numerical value and the unit symbol. (UNIT_SPACE[1])
Suggestions: 3.02 KB
Rule: https://community.languagetool.org/rule/show/UNIT_SPACE?lang=en-US&subId=1
Category: PUNCTUATION
tests/README-templating.md|63 col 101| Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE[1])
Suggestions: , and
URL: https://languagetool.org/insights/post/grammar-what-are-compound-sentences/
Rule: https://community.languagetool.org/rule/show/COMMA_COMPOUND_SENTENCE?lang=en-US&subId=1
Category: PUNCTUATION

Annotations

Check notice on line 51 in docs/modules/trino/pages/usage-guide/operations/graceful-shutdown.adoc

See this annotation in the file changed.

@github-actions github-actions / LanguageTool

[LanguageTool] docs/modules/trino/pages/usage-guide/operations/graceful-shutdown.adoc#L51

A comma may be missing after the conjunctive/linking adverb ‘Currently’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
Suggestions: `Currently,`
URL: https://languagetool.org/insights/post/linking-words/ 
Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
Category: PUNCTUATION
Raw output
docs/modules/trino/pages/usage-guide/operations/graceful-shutdown.adoc:51:360: A comma may be missing after the conjunctive/linking adverb ‘Currently’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA[1])
 Suggestions: `Currently,`
 URL: https://languagetool.org/insights/post/linking-words/ 
 Rule: https://community.languagetool.org/rule/show/SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA?lang=en-US&subId=1
 Category: PUNCTUATION