Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass auto_mkdir in fsspec write #463

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Pass auto_mkdir in fsspec write #463

merged 1 commit into from
Sep 18, 2023

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Sep 18, 2023

Related Issue(s):

Description:

No changelog needed. Discovered due to CI breaks.

PR checklist:

  • Code is formatted (run scripts/format).
  • Code lints properly (run scripts/lint).
  • Tests pass (run scripts/test).
  • Documentation has been updated to reflect changes, if applicable.
  • Changes are added to the CHANGELOG.

We were implicitly relying on behavior fixed by
fsspec/filesystem_spec#1358.
@gadomski gadomski requested a review from jsignell September 18, 2023 12:11
@gadomski gadomski self-assigned this Sep 18, 2023
Copy link
Member

@jsignell jsignell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but do we need to set a min for fsspec?

@gadomski
Copy link
Member Author

Don't think so, the minimum requirements check passed which exercises a much older version: https://github.com/stac-utils/stactools/actions/runs/6222305009/job/16885983910?pr=463#step:5:16. (🎉 min requirements check!)

@gadomski gadomski merged commit 4c19ed6 into main Sep 18, 2023
18 checks passed
@gadomski gadomski deleted the fix-fsspec-automkdir branch September 18, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants