Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👍 support ruby-lsp 0.20.x #44

Merged
merged 2 commits into from
Oct 19, 2024
Merged

👍 support ruby-lsp 0.20.x #44

merged 2 commits into from
Oct 19, 2024

Conversation

byplayer
Copy link
Contributor

change ruby-lsp version from 0.19x to 0.20x.

The interface of on_call_node and index.add has been changed so I fix it.

@st0012
Copy link
Owner

st0012 commented Oct 18, 2024

@byplayer Thanks for the PR. Can you also run bundle exec tapioca gem to make sure rbi files are up-to-date too?

@byplayer
🐛 update rbi files
8143902 
I update rbi files.
@byplayer
Copy link
Contributor Author

@st0012
I run bundle exec tapioca gem to update rbi files.
Could you recheck it?

st0012
st0012 approved these changes Oct 19, 2024
View reviewed changes
Copy link
Owner

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@st0012 st0012 merged commit 41d81e8 into st0012:main Oct 19, 2024
3 checks passed
@byplayer byplayer deleted the support_lsp_0.20 branch November 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byplayer @st0012