arm: fix build on Thumb-only architectures #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building tinymembench for ARM Cortex-M currently fails, because the arm-neon.S file contains ARM code that doesn't build on Thumb-only architectures. To account for this and fix the build for Cortex-M, this patch adjusts the compile time condition to also verify that the architecture supports the ARM instruction set, by testing the __ARM_ARCH_ISA_ARM compiler define. Signed-off-by: Thomas Petazzoni <[email protected]>
buildroot-auto-update
pushed a commit
to buildroot/buildroot
that referenced
this pull request
Nov 13, 2016
This commit adds a patch to the tinymembench package that fixes the build on Thumb-only architectures such as ARM Cortex-M. The patch has been submitted upstream in ssvb/tinymembench#13. Fixes: http://autobuild.buildroot.net/results/5f0148cef22b3b9aee691e1702722a0bbc68c8e8/ Signed-off-by: Thomas Petazzoni <[email protected]>
|
Thanks for the patch. What kind of Cortex-M system is that? I'm kinda surprised that tinymembench even works on such hardware, because of the use of mmap and relatively high memory allocation requirements (more than 64MiB). Do you have a tinymembench log from it? We have a lot of results from different systems reported in the wiki: https://github.com/ssvb/tinymembench/wiki |
|
I have tested it on actual hardware, this is merely a build fix. |
|
In my experience, untested fixes for compilation errors or warnings tend to do more harm than good. I guess it's up to me to check what can be done to add proper Cortex-M support. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building tinymembench for ARM Cortex-M currently fails, because the
arm-neon.S file contains ARM code that doesn't build on Thumb-only
architectures. To account for this and fix the build for Cortex-M,
this patch adjusts the compile time condition to also verify that the
architecture supports the ARM instruction set, by testing the
__ARM_ARCH_ISA_ARM compiler define.
Signed-off-by: Thomas Petazzoni [email protected]