Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keyring to v2 #81

Merged
merged 61 commits into from
Sep 19, 2023
Merged

Update keyring to v2 #81

merged 61 commits into from
Sep 19, 2023

Conversation

Powersource
Copy link
Contributor

Based on #75

For #80

Powersource and others added 30 commits July 27, 2023 16:37
@Powersource
Rewrite listAuthors to not use keyring
925479c
@Powersource
Ignore pnpm lock
258cacd
@Powersource
Don't use keyring listAuthors to setup replication
8d5c6bf
@Powersource
Remove tribes.registerAuthors
45bf22b
@Powersource
Stop depending on keyring.processAddMembers
cb0cfd0
@Powersource
Lint
d4db5ff
@Powersource
Try to log more on invite test err
12bf6be
@Powersource @mixmix
Apply suggestions from code review
5fc9434 
Co-authored-by: mix irving <[email protected]>
@Powersource
Refactor away promise in replication setup
7a440b4
@Powersource
Remove commented code
2af905b
@mixmix
try things to debug test
7300f77
@mixmix
reveal the ACTUAL culprit
1220936
@Powersource
Replace use of keystore.author.groupKeys
764200f
@Powersource
Filter for dupe msgs in getgrouptangle
3563122
@Powersource
Don't rebuild if we're the adder
ade51b3
@Powersource
Use db1 in rebuild-manager tests
ef11281
@Powersource
Skip broken rebuild test
2d7a2a5
@Powersource
Fix replicate test
c3c2da0
@Powersource
Fix replicate better
21d6334
@Powersource
Fix unbox test
6dab626
@Powersource
Fix standard complaint
94627ea
@Powersource
Fix rebuild test
1725ebc
@mixmix
update CI to Node >=12
3badae0
@mixmix
revert ?. optional-chaining, we must support Node 12 still
ca89f70
@mixmix
seperate unbox test-vectors into different test
5aa6532
@mixmix
remove deprecated tests for "application"
851f45b
@mixmix
upgrade [email protected]
9315d07
@mixmix
try to upgrade npm before npm ci
9549e77
@mixmix
npm i -g npm@9
c14eebb
@mixmix
revert lockfile to v2
9b79ff4
@Powersource Powersource changed the title Update keyring to latest Update keyring to v2 Sep 12, 2023
@Powersource Powersource requested a review from mixmix September 12, 2023 15:30
@Powersource Powersource marked this pull request as ready for review September 12, 2023 15:30
@Powersource
Copy link
Contributor Author

This was a decent chunk of changes so I'll mark this PR as ready now and do later versions in (a) separate PR(s).

@Powersource
Copy link
Contributor Author

all tests passing locally

@socket-security
Copy link

socket-security bot commented Sep 12, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

@Powersource Powersource mentioned this pull request Sep 14, 2023
Merged
Base automatically changed from keyring-no-members to master September 18, 2023 04:53
@Powersource Powersource mentioned this pull request Sep 18, 2023
Closed
3 tasks
@mixmix
Copy link
Member

mixmix commented Sep 19, 2023

Nice clean one, and the tests are all passing ☮️
MERGING

@mixmix mixmix merged commit fe55f23 into master Sep 19, 2023
8 checks passed
@mixmix mixmix deleted the new-keyring branch September 19, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix mixmix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Powersource @mixmix