Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get to run on node 18 #2

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Get to run on node 18 #2

merged 3 commits into from
Jan 20, 2024

Conversation

Powersource
Copy link
Contributor

Or idk if it's node 18 specifically that broke it, but when i pulled the repo 1. it didn't manage to pnpm i because of rsjs and 2. tests didn't pass because of a few small issues.

Needed as part of https://gitlab.com/ahau/ahau/-/issues/34 where one of the tasks is listed as "ssb-profile, optimize the Find by using ssb-search2 (need to modify ssb-search2 for that)". I'll make another PR for that change.

@Powersource
Copy link
Contributor Author

damn how is rsjs managing to sneak into ci

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] Transitive: environment, eval, filesystem, network, shell +327 21.1 MB

🚮 Removed packages: npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Deprecated license npm/[email protected]
  • License: LGPL-3.0
Deprecated license npm/[email protected]
  • License: LGPL-3.0

View full report↗︎

Next steps

What is a deprecated license?

(Experimental) License is deprecated which may have legal implications regarding the package's use.

Update or change the license to a well-known or updated license.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Powersource
Copy link
Contributor Author

passing locally and installing in ci now, but getting this in ci

✖ four posts
    -------------
      operator: equal
      expected: 4
      actual:   2
      at: <anonymous> (/home/runner/work/ssb-search2/ssb-search2/test/index.js:72:9)
      stack: |-
  Error: four posts
  at Test.assert [as _assert] (/home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:479:48)
  at Test.strictEqual (/home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/tape/lib/test.js:661:7)
  at /home/runner/work/ssb-search2/ssb-search2/test/index.js:72:9
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/reduce.js:10:5
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/sinks/drain.js:26:24
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/filter.js:17:11
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/flatten.js:35:20
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/map.js:19:9
  at readable (/home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected][email protected]/node_modules/jitdb/operators.js:444:7)
  at /home/runner/work/ssb-search2/ssb-search2/node_modules/.pnpm/[email protected]/node_modules/pull-stream/throughs/map.js:11:7

@Powersource
Copy link
Contributor Author

Powersource commented Jan 20, 2024

hmm can't actually find evidence this module ever passed in ci, so gonna call in the reviewers anyway 🤷

@Powersource Powersource requested a review from staltz January 20, 2024 00:13
Copy link
Member

@staltz staltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, pretty innocent PR to merge. Thanks.

@staltz staltz merged commit 634969e into main Jan 20, 2024
1 of 4 checks passed
@staltz staltz deleted the node-18 branch January 20, 2024 09:11
@staltz
Copy link
Member

staltz commented Jan 20, 2024

I merged it myself because I have the npm access, and want to publish this now. As a major, I guess, because of breaking changes in ssb-db2 going downstream.

@staltz
Copy link
Member

staltz commented Jan 20, 2024

Also invited you to npm owner this.

@Powersource Powersource mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants