-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get to run on node 18 #2
Conversation
damn how is rsjs managing to sneak into ci |
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected] |
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a deprecated license?(Experimental) License is deprecated which may have legal implications regarding the package's use. Update or change the license to a well-known or updated license. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
passing locally and installing in ci now, but getting this in ci
|
hmm can't actually find evidence this module ever passed in ci, so gonna call in the reviewers anyway 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, pretty innocent PR to merge. Thanks.
I merged it myself because I have the npm access, and want to publish this now. As a major, I guess, because of breaking changes in ssb-db2 going downstream. |
Also invited you to npm owner this. |
Or idk if it's node 18 specifically that broke it, but when i pulled the repo 1. it didn't manage to
pnpm i
because of rsjs and 2. tests didn't pass because of a few small issues.Needed as part of https://gitlab.com/ahau/ahau/-/issues/34 where one of the tasks is listed as "ssb-profile, optimize the Find by using ssb-search2 (need to modify ssb-search2 for that)". I'll make another PR for that change.