-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make loadOrCreate accept generate options #101
Make loadOrCreate accept generate options #101
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my read of this this is a non-breaking change right?
Seems good to me (reviewed on phone)
Yep should be non-breaking |
As said on the tribes2 PR, I think this change is quite deep in the SSB stack and breaks a strong (legacy) assumption that classic feed format is used everywhere. E.g. there are places where we convert from a multiserver/shs address to SSB ID, by plucking the So could we put this PR on hold or close it? |
@staltz why not give the user the option at least? And if not the feed format, this will allow the user to set the key seed too. |
Good point |
If this is a non-breaking change @Powersource I recommend we merge + publish |
@mixmix merged now. will you publish? |
I'm working on ssbc/ssb-tribes2#10 and to do that I need to adapt the tests there. And those tests create their keys with loadOrCreate.