-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hasDiskAccess config #425
Conversation
tests passing locally (or they're at least not failing more than on master :p ) |
The demo works now without the patch! ssbc/ssb-tribes2-demo#12 |
Benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this seems okay.
v7.2.0 |
woops i think setting this to |
Benchmark results
|
In ssb-tribes2-demo we currently have to patch ssb-db2 to get it to run, see ssbc/ssb-tribes2-demo#11 https://github.com/ssbc/ssb-tribes2-demo/blob/3d4425fec46894b4c0db601c312b65e9d58fe9ae/patches/ssb-db2%2B7.1.1.patch This config option should allow us to remove that patch.
I didn't add a test here but I'll make a PR in ssb-tribes2-demo where i test it