-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support passing in pValue #324
Conversation
Some numbers:
So the more level plugins you have, the better it gets. It might also be a good idea to pass things like pContent to level plugins. Maybe even jitdb. |
Benchmark results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh silly me, now I see why we can't move the pValue calculation. Sorry for that :)
@arj03 By the way, I just had an idea for using WeakMap so that we don't need to recalculate any of these pointers. It could be put into BIPF and would work transparently. Then we could revert these pValue changes and we would still have the same performance benefits |
Uhh nice! |
Benchmark results
|
This is what I have used to test ssbc/jitdb#208. So not really ready yet.
Also we can do the same trick here for level indexes :)