-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP new_installer #333
WIP new_installer #333
Conversation
package.json
Outdated
@@ -91,7 +92,7 @@ | |||
"scuttle-thread": "^1.0.1", | |||
"setimmediate": "^1.0.5", | |||
"ssb-about": "^2.0.1", | |||
"ssb-ahoy": "github:ssbc/ssb-ahoy#add_config_picker", | |||
"ssb-ahoy": "github:ssbc/ssb-ahoy#electron_4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this version of ssb_ahoy
is the same as add_config_picker
branch except:
- it uses electron 4.2.0
- it has no
cross-script
/electron-builder
(not quite sure what that will do)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, I think as long as the ssb-ahoy Electron ABI matches the Patchbay Electron ABI then this should work great. No electron-builder install-app-deps
necessary since Patchbay rebuilds all dependencies to match its Electron ABI.
I'm not sure what's causing that, but it's working wonderfully for me. 🎉 I made some dependency changes, maybe |
package.json
Outdated
@@ -101,7 +102,7 @@ | |||
"ssb-ebt": "^5.5.2", | |||
"ssb-friend-pub": "^1.0.5", | |||
"ssb-friends": "^3.1.12", | |||
"ssb-invite": "^2.0.3", | |||
"ssb-invite": "^2.1.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @christianbundy head up this introduced bugs in windows install!
ssbc/ssb-invite#7
Thanks! I'll look out for those bugs in Patchwork's Windows build. I don't know what the new ssb-invite code does, my change just unbreaks package.json: ssbc/ssb-invite@a25d351
On Wed, May 15, 2019, at 21:39, mix irving wrote:
***@***.**** commented on this pull request.
In package.json <#333 (comment)>:
> @@ -101,7 +102,7 @@
"ssb-ebt": "^5.5.2",
"ssb-friend-pub": "^1.0.5",
"ssb-friends": "^3.1.12",
- "ssb-invite": "^2.0.3",
+ "ssb-invite": "^2.1.3",
…
hey @christianbundy <https://github.com/christianbundy> head up this introduced bugs in windows install!
ssbc/ssb-invite#7 <ssbc/ssb-invite#7>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#333?email_source=notifications&email_token=AAEDIZBAHOUGTVZAPV32FDDPVTQQZA5CNFSM4HMWNKC2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOBYZEHQQ#pullrequestreview-238175170>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAEDIZGS34NUD5NYJ7SASYDPVTQQZANCNFSM4HMWNKCQ>.
|
@christianbundy here's my work so far.
Current state:
npm install
npm start
yay! works (linux)npm run dist
creates an AppImage fine./dist/patchbay_7.17.0.AppImage
crashes hardHaven't been able to get beyond: