Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP new_installer #333

Merged
merged 12 commits into from
May 16, 2019
Merged

WIP new_installer #333

merged 12 commits into from
May 16, 2019

Conversation

mixmix
Copy link
Member

@mixmix mixmix commented May 14, 2019

@christianbundy here's my work so far.

Current state:

  • ✔️ npm install
  • ✔️ npm start yay! works (linux)
  • ✔️ npm run dist creates an AppImage fine
  • ./dist/patchbay_7.17.0.AppImage crashes hard

Haven't been able to get beyond:

/tmp/.mount_patchbIOQqxL/patchbay: symbol lookup error: /tmp/.org.chromium.Chromium.FYBWbm: undefined symbol: crypto_core_ed25519_scalarbytes

@mixmix mixmix changed the base branch from master to ahoy May 14, 2019 05:33
package.json Outdated
@@ -91,7 +92,7 @@
"scuttle-thread": "^1.0.1",
"setimmediate": "^1.0.5",
"ssb-about": "^2.0.1",
"ssb-ahoy": "github:ssbc/ssb-ahoy#add_config_picker",
"ssb-ahoy": "github:ssbc/ssb-ahoy#electron_4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this version of ssb_ahoy is the same as add_config_picker branch except:

  • it uses electron 4.2.0
  • it has no cross-script / electron-builder (not quite sure what that will do)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, I think as long as the ssb-ahoy Electron ABI matches the Patchbay Electron ABI then this should work great. No electron-builder install-app-deps necessary since Patchbay rebuilds all dependencies to match its Electron ABI.

@mixmix mixmix requested a review from christianbundy May 14, 2019 05:38
@christianbundy
Copy link
Contributor

christianbundy commented May 14, 2019

I'm not sure what's causing that, but it's working wonderfully for me. 🎉

Screenshot from 2019-05-14 10-43-28

I made some dependency changes, maybe npm ci && npm run dist to see if maybe there's an old sodium-native v1.x.x hanging in your node_modules directory? I'll upload my build artifact just in case it's helpful: https://send.firefox.com/download/9912e4dc17f9d023/#BK5a9PtOq_IQXG29Yhhmeg

package.json Outdated
@@ -101,7 +102,7 @@
"ssb-ebt": "^5.5.2",
"ssb-friend-pub": "^1.0.5",
"ssb-friends": "^3.1.12",
"ssb-invite": "^2.0.3",
"ssb-invite": "^2.1.3",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @christianbundy head up this introduced bugs in windows install!
ssbc/ssb-invite#7

@mixmix mixmix merged commit 6e716f2 into ahoy May 16, 2019
@mixmix mixmix deleted the new_installer branch May 16, 2019 04:41
@christianbundy
Copy link
Contributor

christianbundy commented May 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants