Skip to content

Commit

Permalink
cu_cp,rrc: improve function name
Browse files Browse the repository at this point in the history
  • Loading branch information
FabianEckermann committed Jun 21, 2024
1 parent ac07f4c commit 80d3e94
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion include/srsran/rrc/rrc_ue.h
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ class rrc_ue_cu_cp_ue_notifier
virtual void update_security_context(security::security_context sec_ctxt) = 0;

/// \brief Perform horizontal key derivation
virtual void horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn) = 0;
virtual void perform_horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn) = 0;
};

/// Struct containing all information needed from the old RRC UE for Reestablishment.
Expand Down
4 changes: 2 additions & 2 deletions lib/cu_cp/adapters/rrc_ue_adapters.h
Original file line number Diff line number Diff line change
Expand Up @@ -154,10 +154,10 @@ class rrc_ue_cu_cp_ue_adapter : public rrc_ue_cu_cp_ue_notifier
}

/// \brief Perform horizontal key derivation
void horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn) override
void perform_horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn) override
{
srsran_assert(ue != nullptr, "CU-CP UE must not be nullptr");
return ue->get_security_manager().horizontal_key_derivation(target_pci, target_ssb_arfcn);
return ue->get_security_manager().perform_horizontal_key_derivation(target_pci, target_ssb_arfcn);
}

private:
Expand Down
2 changes: 1 addition & 1 deletion lib/cu_cp/ue_security_manager/ue_security_manager_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ void ue_security_manager::update_security_context(security::security_context sec
sec_context = sec_ctxt;
}

void ue_security_manager::horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn)
void ue_security_manager::perform_horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn)
{
sec_context.horizontal_key_derivation(target_pci, target_ssb_arfcn);
}
2 changes: 1 addition & 1 deletion lib/cu_cp/ue_security_manager/ue_security_manager_impl.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ue_security_manager
[[nodiscard]] security::sec_as_config get_rrc_as_config() const;
[[nodiscard]] security::sec_128_as_config get_rrc_128_as_config() const;
void update_security_context(security::security_context sec_ctxt);
void horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn);
void perform_horizontal_key_derivation(pci_t target_pci, unsigned target_ssb_arfcn);

private:
security_manager_config cfg;
Expand Down
2 changes: 1 addition & 1 deletion lib/rrc/ue/procedures/rrc_reestablishment_procedure.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ void rrc_reestablishment_procedure::transfer_reestablishment_context_and_update_
// freq_and_timing must be present, otherwise the RRC UE would've never been created
uint32_t ssb_arfcn = context.cfg.meas_timings.begin()->freq_and_timing.value().carrier_freq;
cu_cp_ue_notifier.update_security_context(old_ue_reest_context.sec_context);
cu_cp_ue_notifier.horizontal_key_derivation(context.cell.pci, ssb_arfcn);
cu_cp_ue_notifier.perform_horizontal_key_derivation(context.cell.pci, ssb_arfcn);
logger.log_debug("Refreshed keys horizontally. pci={} ssb-arfcn={}", context.cell.pci, ssb_arfcn);
}

Expand Down
2 changes: 1 addition & 1 deletion lib/rrc/ue/rrc_ue_impl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ rrc_ue_impl::rrc_ue_impl(rrc_pdu_f1ap_notifier& f1ap_pdu_notifie
if (!rrc_context.value().is_inter_cu_handover) {
cu_cp_ue_notifier.update_security_context(rrc_context.value().sec_context);
}
cu_cp_ue_notifier.horizontal_key_derivation(cell_.pci, cell_.ssb_arfcn);
cu_cp_ue_notifier.perform_horizontal_key_derivation(cell_.pci, cell_.ssb_arfcn);

// Create SRBs.
for (const auto& srb : rrc_context.value().srbs) {
Expand Down

0 comments on commit 80d3e94

Please sign in to comment.