-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modify image so gopher eyes are visible #176
Conversation
Signed-off-by: Francesc Campoy <[email protected]>
Even after reading the documentation I still do not understand how to push this to staging. Please clarify this, it's quite confusing and annoying. |
Not sure about staging - I see no point in it for the new content in the blog. The changes are easily tested locally. So after I merged this PR, I created https://github.com/src-d/blog/releases/tag/v1.1.10 and it went live through CD. |
@campoy It appears that I've got admin rights here so I gave the write permissions to devrel team so that you should be able to merge now. At the same time you are supposed to be an admin - all leads are admins here. I guess your position is not fully set on GitHub, you need to consult with Máximo. |
I think that deploying in staging is a good way to validate all web sites (or to add a screenshot in the PR). Now that CD works like a charm, we could be benefited a lot of staging, and we could meet to find the best way to proceed. From the current guidelines guide/engineering/continuous-delivery.md#deploying-into-staging
it's trying to explain that every new commit in staging causes a deploy into staging. |
Basically my doubt is whether staging is a branch or a tag and what rights I need to have in order to do these. |
Staging is a branch. |
BTW @dpordomingo staging is completely independent of master and should not be merged, correct? |
Does it answer your question @vmarkovtsev ? I tried to explain it in the guide, but since there appeared that much doubts, I think you should help me to improve it in order to make it more clear. |
Probably worth writing it down as a step by step on how to deploy something a change to staging then prod. |
Issue opened. Here is the link in case you want to follow its progress, or provide more feedback. |
Signed-off-by: Francesc Campoy [email protected]