Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify image so gopher eyes are visible #176

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Conversation

campoy
Copy link
Contributor

@campoy campoy commented Jan 9, 2018

Signed-off-by: Francesc Campoy [email protected]

@vmarkovtsev vmarkovtsev merged commit b956f3c into src-d:master Jan 9, 2018
@campoy
Copy link
Contributor Author

campoy commented Jan 9, 2018

Even after reading the documentation I still do not understand how to push this to staging.
Am I supposed to merge it to staging first? Can I even do that or do I need extra rights?

Please clarify this, it's quite confusing and annoying.

cc: @mcuadros @vmarkovtsev

@vmarkovtsev
Copy link
Contributor

Not sure about staging - I see no point in it for the new content in the blog. The changes are easily tested locally.

So after I merged this PR, I created https://github.com/src-d/blog/releases/tag/v1.1.10 and it went live through CD.

@vmarkovtsev
Copy link
Contributor

@campoy It appears that I've got admin rights here so I gave the write permissions to devrel team so that you should be able to merge now. At the same time you are supposed to be an admin - all leads are admins here. I guess your position is not fully set on GitHub, you need to consult with Máximo.

@dpordomingo
Copy link
Contributor

I think that deploying in staging is a good way to validate all web sites (or to add a screenshot in the PR). Now that CD works like a charm, we could be benefited a lot of staging, and we could meet to find the best way to proceed.

From the current guidelines guide/engineering/continuous-delivery.md#deploying-into-staging

Whenever staging branch is updated, drone automatically deploys it to Staging environment

it's trying to explain that every new commit in staging causes a deploy into staging.
If you feel that the guides are not clear enough, please open an issue to keep it in mind now that documentation is a company priority. (PRs are welcomed too, for sure)

@campoy
Copy link
Contributor Author

campoy commented Jan 9, 2018

Basically my doubt is whether staging is a branch or a tag and what rights I need to have in order to do these.

@dpordomingo
Copy link
Contributor

Staging is a branch.
I think you should need push privileges into src-d/blog repo. I think it should be granted by @mcuadros but now that @vmarkovtsev did some magic I think you can already do it.

@vmarkovtsev
Copy link
Contributor

BTW @dpordomingo staging is completely independent of master and should not be merged, correct?

@dpordomingo
Copy link
Contributor

dpordomingo commented Jan 10, 2018

  • staging should be never merged over any other branch, specially never ever over master
  • master can be merged over staging to update it with new things. When there are no other thing being tested in staging, staging branch can be reseyed from master or from any other branch.

Does it answer your question @vmarkovtsev ?

I tried to explain it in the guide, but since there appeared that much doubts, I think you should help me to improve it in order to make it more clear.

@campoy
Copy link
Contributor Author

campoy commented Jan 10, 2018

Probably worth writing it down as a step by step on how to deploy something a change to staging then prod.

@dpordomingo
Copy link
Contributor

Issue opened. Here is the link in case you want to follow its progress, or provide more feedback.
src-d/guide#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants