Keyboard Event Which is Depreciated #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://caniuse.com/keyboardevent-which Though it's usable, it's been depreciated for a while, so is bad practice to use.
joris-rotteveel
suggested changes
Nov 15, 2020
ie11 specifically does. It's a piece of non-compat in the Internet Explorer spec.
|
holloway
reviewed
Nov 16, 2020
joris-rotteveel
suggested changes
Nov 16, 2020
joris-rotteveel
approved these changes
Nov 18, 2020
|
@GeorgeWL Thanks for your contribution! |
|
@GeorgeWL have merged but noticed our tests were failing. The correct value for the SPACE key should be either |
|
ah darn it, i can make a new pr to fix if you like, unless you already have fixed that? |
|
I have fixed it on our end, but because you mentioned you copied it from another of your projects I thought you might wanted to know. Thanks again for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://caniuse.com/keyboardevent-which
Though it's usable, it's been depreciated for a while, so is bad practice to use.