Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccordionItem preserving uuid on instance #285

Merged
merged 3 commits into from
Aug 6, 2020
Merged

AccordionItem preserving uuid on instance #285

merged 3 commits into from
Aug 6, 2020

Conversation

holloway
Copy link

@holloway holloway commented Aug 6, 2020

No description provided.

@coveralls
Copy link

coveralls commented Aug 6, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 87.891% when pulling 5c1b365 on bug/accordion-item-instance-uuid into 1136095 on master.

liamjohnston
liamjohnston reviewed Aug 6, 2020
View reviewed changes
src/components/AccordionItem.tsx Outdated
if (rest.id) {
assertValidHtmlId(rest.id);
}
``;
Copy link
Contributor

@liamjohnston liamjohnston Aug 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is "``;"?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah whoops, removing...

liamjohnston
liamjohnston approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@liamjohnston liamjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@holloway holloway merged commit 98a9889 into master Aug 6, 2020
@holloway holloway mentioned this pull request Aug 6, 2020
Closed
@holloway holloway deleted the bug/accordion-item-instance-uuid branch August 6, 2020 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamjohnston liamjohnston liamjohnston approved these changes

@synecdokey synecdokey Awaiting requested review from synecdokey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holloway @coveralls @liamjohnston