Remove unnecessary servlet response manipulations

[dsyer]

No description provided.

[agrison]

I don't see why this is a very big problem (related to uglyness) for the BE to drive the URL for these pagination steps.

With the changes you propose, the URL are no more bookmarkable when changing page, the URL doesn't get updated anymore and stays on /owners/find instead of say /owners/find?lastName=Davis&page=1.

We would need to fix that, also I think on vets.html but this was a missing feature probably, it should have worked the same way it worked on searching owners.

[dsyer]

You don't think servlet API references in controllers is ugly? I suppose it's not for me to say.

Anyway, I see what you mean about the URL query params being bookmarkable - I don't recall ever seeing them, but I was probably not looking hard enough. The vets link has no query params so I might hack the PR around until it is the smallest it can be without changing bookmarks.

[dsyer]

I updated the OwnerController to preserve the form query params in the hx-push-url using HtmxResponse from the HTMX library. The other endpoints all seem fine without changing the controllers, or maybe I missed something.

[wimdeblauwe]

You could replace this with hx-push-url="true" and it should work just the same.

[dsyer]

Done. I also replaced all the unnecessary HttpServletRequest and HttpServletResponse method parameters. I wonder if we even need the HtmxResponse (controller methods can return strings if there is only one view to render), but I didn't go that far.