Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade cronjobs from v1beta1 to v1 #533

Closed
wants to merge 2 commits into from
Closed

Upgrade cronjobs from v1beta1 to v1 #533

wants to merge 2 commits into from

Conversation

SurajSharmaP
Copy link

No description provided.

@SurajSharmaP
Copy link
Author

SurajSharmaP commented Mar 7, 2023 •
edited
Loading

This is to fix #529

I've changed the README to reflect the fact that cronjobs were stable from v1.21 so this change will effectively mean that v1.19 and v1.20 will not be supported fully anymore.

@onobc onobc added the status/need-triage Team needs to triage and take a first look label Mar 10, 2023
@onobc
Copy link
Contributor

onobc commented Mar 17, 2023

Thanks for the contribution @SurajSharmaP . The team needs to verify that the breaking change for 1.19 and 1.20 is acceptable before we merge this in. We should have an answer w/in a week. In the meantime, I noticed the CI is complaining about a checkstyle. If you get a chance to push an update that would be great. Thanks

@SurajSharmaP
Copy link
Author

SurajSharmaP commented Mar 18, 2023 •
edited
Loading

Thanks @onobc. Considering that EOL for 1.19 was more than a year ago, it should be easy to move forward with these changes

@onobc
Copy link
Contributor

onobc commented Mar 21, 2023

Hi @SurajSharmaP ,
While I would love nothing more than to support 1.21+ only, we have existing customers running on the older k8s versions. We discussed this in team meeting today but still need a bit more time to understand the impact of this change. Thanks for your patience.

@corneil corneil mentioned this pull request Mar 31, 2023
Closed
@corneil
Copy link
Contributor

corneil commented Apr 3, 2023

Applied to 2.9.0-SNAPSHOT in spring-cloud/spring-cloud-deployer#378

@corneil corneil closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/need-triage Team needs to triage and take a first look
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SurajSharmaP @onobc @corneil