Implement KubernetesActuatorTemplate #478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Jan 13, 2022
There was a problem hiding this comment.
@dturanski looking good. I really like the mock web server - good call.
src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesActuatorTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesActuatorTemplate.java
Outdated
Show resolved
Hide resolved
src/main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesActuatorTemplate.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppInstanceStatus.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppInstanceStatus.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppInstanceStatus.java
Outdated
Show resolved
Hide resolved
...va/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppDeployerIntegrationIT.java
Show resolved
Hide resolved
.../java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesActuatorTemplateTests.java
Show resolved
Hide resolved
onobc
reviewed
Jan 20, 2022
...main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAutoConfiguration.java
Show resolved
Hide resolved
onobc
reviewed
Jan 20, 2022
onobc
reviewed
Feb 11, 2022
src/main/java/org/springframework/cloud/deployer/spi/kubernetes/DefaultContainerFactory.java
Show resolved
Hide resolved
onobc
reviewed
Feb 11, 2022
...main/java/org/springframework/cloud/deployer/spi/kubernetes/KubernetesAppInstanceStatus.java
Show resolved
Hide resolved
onobc
reviewed
Feb 11, 2022
There was a problem hiding this comment.
@dturanski looks good. One question around logging creds that I would like to get resolution on (and the newlines in json are of the nit variety). Other than that, looks good.
onobc
approved these changes
Feb 11, 2022
|
Closed via a932b93 |
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on spring-cloud/spring-cloud-deployer#352