Updated based on code review

spring-cloud · Dec 13, 2019 · 9455681 · 9455681
1 parent 6d1a617
commit 9455681
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/...java/org/springframework/cloud/deployer/spi/scheduler/kubernetes/KubernetesScheduler.java b/...java/org/springframework/cloud/deployer/spi/scheduler/kubernetes/KubernetesScheduler.java
@@ -86,7 +86,7 @@ public void schedule(ScheduleRequest scheduleRequest) {
 			}
 
 			invalidCronExceptionMessage = getExceptionMessageForField(e, SCHEDULE_METADATA_FIELD_NAME);
-			if (isScheduleNameTooLong(invalidCronExceptionMessage)) {
+			if (validationScheduleNameLength(invalidCronExceptionMessage)) {
 				throw new CreateScheduleException(invalidCronExceptionMessage, e);
 			}
 
@@ -211,11 +211,7 @@ private void setImagePullSecret(ScheduleRequest scheduleRequest, CronJob cronJob
 		}
 	}
 
-	private boolean isScheduleNameTooLong(String message ) {
-		boolean result = false;
-		if(StringUtils.hasText(message) && message.contains("must be no more than") && message.endsWith("characters")) {
-			result = true;
-		}
-		return result;
+	private boolean validationScheduleNameLength(String message ) {
+		return (StringUtils.hasText(message) && message.contains("must be no more than") && message.endsWith("characters"));
 	}
 }