Add keycloak integration test #6085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneil
force-pushed
the
corneil/add-keycloak-integration-test
branch
from
53c3975 to
bc49898
Compare
onobc
requested changes
Dec 10, 2024
...st/java/org/springframework/cloud/common/security/support/DefaultAuthoritiesMapperTests.java
Outdated
Show resolved
Hide resolved
...st/java/org/springframework/cloud/common/security/support/DefaultAuthoritiesMapperTests.java
Outdated
Show resolved
Hide resolved
.../test/java/org/springframework/cloud/dataflow/integration/test/db/AbstractDataflowTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/cloud/dataflow/unit/test/DataFlowAuthenticationTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/cloud/dataflow/unit/test/DataFlowAuthenticationTests.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/springframework/cloud/dataflow/unit/test/DataFlowAuthenticationTests.java
Outdated
Show resolved
Hide resolved
cppwfs
requested changes
Dec 10, 2024
spring-cloud-dataflow-server/src/test/resources/application-keycloak-client.yaml
Outdated
Show resolved
Hide resolved
cppwfs
approved these changes
Dec 12, 2024
Adds Keycloak integration test to DataflowOAuthIT Adds Authorities mapping test similar to keycloak role usage. Added scripts to src/local for testing keycloak locally with preconfigured roles / group and user. Fix duplicate output for skipper and dataflow and some output frames. Refactor DefaultAuthoritiesMapperTests for JUnit 5 conventions. Rename DataflowOAuthIT methods for JUnit 5 conventions. Add testcontainers-keycloak to dependency management in spring-cloud-dataflow-parent. Updates src/local/README.md with information on the scripts. Removes create-containers.sh that used jib Adds comment to application-dataflow-keycloak.yaml on client-secret.
corneil
force-pushed
the
corneil/add-keycloak-integration-test
branch
from
94862fd to
78bf012
Compare
|
Squashed all changes into one commit which allowed dropping some unneeded changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Keycloak integration test to DataflowOAuthIT
Adds Authorities mapping test similar to keycloak role usage.
Added scripts to src/local for testing keycloak locally with preconfigured roles / group and user.
NOTES
The Keycloak configuration uses roles and assigns user to a group containing those roles.
The configuration supports both basic auth endpoint like needed by dataflow shell and REST calls and OAuth2 flow needed by the UI. Default user in keycloak realm is
joe:password.