Deprecate search field for taskName search in TaskDefinitionController #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves spring-cloud#5993 * Remove search as a parameter from the javadoc * Fix docs such that queryParameter descriptions appear in reference docs. * Rename Request Parameters header to Query Parameters Signed-off-by: Glenn Renfro <[email protected]>
onobc
reviewed
Oct 24, 2024
| void findTaskNameContainsSubstring(String taskNameRequestParamName) throws Exception { | ||
| @Test | ||
| void findTaskNameContainsSubstring() throws Exception { | ||
| final String TASK_NAME_REQUEST_PARAMETER = "taskName"; |
There was a problem hiding this comment.
[TinyNit] Please remove the final keyword as we only use them where it adds value (like immutable fields etc..)
onobc
reviewed
Oct 24, 2024
| @@ -411,7 +411,7 @@ void findDslTextContainsSubstring() throws Exception { | |||
|
|
|||
| @Test | |||
| void findByDslTextAndNameBadRequest() throws Exception { | |||
| mockMvc.perform(get("/tasks/definitions").param("dslText", "fo").param("search", "f") | |||
| mockMvc.perform(get("/tasks/definitions").param("dslText", "fo").param("taskName", "f") | |||
There was a problem hiding this comment.
In this case we reference the param by string name rather than constant. I would be in favor of moving the TASK_NAME_REQUEST_PARAMETER to a static final constant or just using "taskName" everywhere.
|
@onobc Thank you for the review!!! Code review comments have been applied. Rebased, Squashed, Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5993