[CI] Remove Maven profile full in favour of using docs for all document generation. #6007
Conversation
.github/workflows/ci-pr.yml
Outdated
| @@ -17,7 +17,7 @@ jobs: | |||
| shell: bash | |||
| timeout-minutes: 75 | |||
| run: | | |||
| ./mvnw -B -s .github/settings.xml -Pdocs clean install --no-transfer-progress | |||
| ./mvnw -B -s .github/settings.xml -Pfull,docs clean install --no-transfer-progress | |||
There was a problem hiding this comment.
What is full vs. docs? I guess I don't understand how full fulfills the PR description of executes rest-docs generation as well.
There was a problem hiding this comment.
I didn't choose the name. We can change to rest-docs to ensure it is unambiguous.
There was a problem hiding this comment.
Having checked:
docsmeans javadocsfullmeans all rest-docs and asciidocs.
How about we rather use javadocs and fulldocs?
There was a problem hiding this comment.
Makes sense to me . @onobc what do you think?
…nd other document generation.
corneil
changed the title
| <skipTests>false</skipTests> | ||
| <includes> | ||
| <include>**/*Documentation.java</include> | ||
| <include>**/*Tests.java</include> |
There was a problem hiding this comment.
We probably want to include the **/*Tests.java to the docs plugin below. WDYT?
There was a problem hiding this comment.
I've changed to the surefire in docs profile to use the package phase which means test phase executes normal unit tests and package phase generates the snippets.
When -DskipTests is present the normal test phase is skipped. When -Pdocs is not provides then the snippets are not generated.
… skip tests and generate documentation but allow for normal tests to execute id -DskipTests are not specified.
…incorrect assumption of where the resources are located. Disable test suites that are not needed to create documentation snippets.
|
The latests commit fixes tests for the actual resources present that do work when doing local deployments. |
|
We have a pass locally fails in CI-PR situation. 😢 |
Improved surefire report plugin config. Fix last failing tests.
corneil
force-pushed
the
corneil/ensure-ci-pr-tests-documentation-generation
branch
from
7cf5109 to
d1d71a1
Compare
|
Rebased, Squashed, Merged. @corneil Thanks for the hard work on this. |
In
spring-cloud-skipper-server-coreI've changed to the surefire indocsprofile to use thepackagephase which meanstestphase executes normal unit tests andpackagephase generates the snippets.When
-DskipTestsis present the normal test phase is skipped. When-Pdocsis not provided then the snippets are not generated.