Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated Version.valueOf with Version.parse #5998

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Replace deprecated Version.valueOf with Version.parse #5998

merged 1 commit into from
Oct 21, 2024

Conversation

cppwfs
Copy link
Contributor

@cppwfs cppwfs commented Oct 18, 2024 •
edited
Loading

Resolves #5997

@onobc
Copy link
Contributor

onobc commented Oct 21, 2024 •
edited
Loading

Is this for #5997? That issue only says "valueOf" is deprecated but it does not say which class that method belongs to. I am guessing its this one.

onobc
onobc approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@onobc onobc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look straightforward to me - thanks for the deprecation removal @cppwfs !

@cppwfs
Copy link
Contributor Author

cppwfs commented Oct 21, 2024

Yes. Thanks for reminding me to putting the Issue number in the comment!

@cppwfs cppwfs merged commit 6c427f9 into spring-cloud:main Oct 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onobc onobc onobc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve valueOf(java.lang.String) Deprecation
2 participants
@cppwfs @onobc