Fix redirect failures from apache client 5.x #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide followRedirect to remove Authorization. Fixes spring-cloud#5989
Provide followRedirect to remove Authorization. Fixes spring-cloud#5989
onobc
reviewed
Nov 1, 2024
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
onobc
reviewed
Nov 1, 2024
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
onobc
requested changes
Nov 1, 2024
onobc
changed the title
onobc
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Excellent work @corneil .
The move to Reactor Netty "is the way" and has greatly reduced the complexity of this class. I am glad you stayed firm on getting this in - worth the wait!
A few minor comments/suggestions - but after those are resolved we should be good to go as far as I'm concerned.
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/dataflow/container/registry/ContainerImageRestTemplateFactory.java
Show resolved
Hide resolved
.../dataflow/container/registry/authorization/DropAuthorizationHeaderOnContainerTestManual.java
Outdated
Show resolved
Hide resolved
.../dataflow/container/registry/authorization/DropAuthorizationHeaderOnContainerTestManual.java
Outdated
Show resolved
Hide resolved
.../dataflow/container/registry/authorization/DropAuthorizationHeaderOnContainerTestManual.java
Show resolved
Hide resolved
…on on using for a manual test. Updated ContainerImageRestTemplateFactory with documentation on extra and improved formatting. Refactored CacheKey in ContainerImageRestTemplateFactory to be a Java Record and include extra to ensure correct behaviour for RestTemplate obtained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided alternative by using Reactor Netty HttpClient that does provide proper redirect handling.
Reason for redirect handler was in deleted
DropAuthorizationHeaderRequestRedirectStrategy