Ensure sub-query use for Job instances. #5563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix find by name query ordering. Fix find by name not found query. Improve test case readability. #5484
Removed .andDo(print())
Removed .andDo(print())
onobc
requested changes
Nov 27, 2023
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java
Outdated
Show resolved
Hide resolved
...main/java/org/springframework/cloud/dataflow/server/repository/JdbcAggregateJobQueryDao.java
Outdated
Show resolved
Hide resolved
.../main/java/org/springframework/cloud/dataflow/server/service/impl/DefaultTaskJobService.java
Show resolved
Hide resolved
...st/java/org/springframework/cloud/dataflow/server/controller/JobInstanceControllerTests.java
Show resolved
Hide resolved
...st/java/org/springframework/cloud/dataflow/server/controller/JobInstanceControllerTests.java
Outdated
Show resolved
Hide resolved
cppwfs
reviewed
Nov 27, 2023
...st/java/org/springframework/cloud/dataflow/server/controller/JobInstanceControllerTests.java
Outdated
Show resolved
Hide resolved
cppwfs
reviewed
Nov 27, 2023
...src/main/java/org/springframework/cloud/dataflow/server/repository/AggregateJobQueryDao.java
Show resolved
Hide resolved
corneil
force-pushed
the
corneil/spring-cloud-dataflow-5484
branch
from
4a9fbb1 to
d8faa9e
Compare
onobc
reviewed
Nov 27, 2023
...st/java/org/springframework/cloud/dataflow/server/controller/JobInstanceControllerTests.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix find by name query ordering.
Fix find by name not found query.
Improve test case readability.
#5484