Update based on code review

Signed-off-by: Glenn Renfro <[email protected]>
spring-cloud · Nov 18, 2024 · b71c6ab · b71c6ab
1 parent 14bc1f4
commit b71c6ab
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/spring-cloud-dataflow-common/spring-cloud-dataflow-common-test-docker/pom.xml b/spring-cloud-dataflow-common/spring-cloud-dataflow-common-test-docker/pom.xml
@@ -51,11 +51,6 @@
 			<artifactId>spring-boot-starter-test</artifactId>
 			<scope>test</scope>
 		</dependency>
-		<dependency>
-			<groupId>org.assertj</groupId>
-			<artifactId>assertj-core</artifactId>
-			<scope>test</scope>
-		</dependency>
 		<dependency>
 			<groupId>junit</groupId>
 			<artifactId>junit</artifactId>

diff --git a/...ataflow/common/test/docker/compose/configuration/AdditionalEnvironmentValidatorTests.java b/...ataflow/common/test/docker/compose/configuration/AdditionalEnvironmentValidatorTests.java
@@ -18,15 +18,14 @@
 import java.util.HashMap;
 import java.util.Map;
 
-import org.junit.Test;
-
+import org.junit.jupiter.api.Test;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
 
 public class AdditionalEnvironmentValidatorTests {
 
 	@Test
-	public void throw_exception_when_additional_environment_variables_contain_docker_variables() {
+	public void throwExceptionWhenAdditionalEnvironmentVariablesContainDockerVariables() {
 		Map<String, String> variables = new HashMap<>();
 		variables.put("DOCKER_HOST", "tcp://some-host:2376");
 		variables.put("SOME_VARIABLE", "Some Value");