Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move functions checking for gem availability to core #578

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

move functions checking for gem availability to core #578

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e75fd20
move functions checking for gem availability to core
wjwitek Feb 10, 2023
8c0f87f
remove pry
wjwitek Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 6 additions & 23 deletions lib/spree/auth/engine.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
require 'devise'
require 'devise-encryptable'
require 'pry'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require 'pry'

I don't think we'll need that 😬

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups 😮


require_relative 'configuration'

module Spree
module Auth
class Engine < Rails::Engine
include Spree::Core::ControllerHelpers::GemChecking

isolate_namespace Spree
engine_name 'spree_auth'

Expand All @@ -30,44 +33,24 @@ def self.activate
Dir.glob(File.join(File.dirname(__FILE__), '../../app/**/*_decorator*.rb')) do |c|
Rails.configuration.cache_classes ? require(c) : load(c)
end
if Spree::Auth::Engine.backend_available?
if backend_available?
Dir.glob(File.join(File.dirname(__FILE__), "../../controllers/backend/*/*/*_decorator*.rb")) do |c|
Rails.configuration.cache_classes ? require(c) : load(c)
end
end
if Spree::Auth::Engine.frontend_available?
if frontend_available?
Dir.glob(File.join(File.dirname(__FILE__), "../../controllers/frontend/**/*_decorator*.rb")) do |c|
Rails.configuration.cache_classes ? require(c) : load(c)
end
end
if Spree::Auth::Engine.api_available?
if api_available?
Dir.glob(File.join(File.dirname(__FILE__), "../../controllers/api/**/*_decorator*.rb")) do |c|
Rails.configuration.cache_classes ? require(c) : load(c)
end
end
ApplicationController.send :include, Spree::AuthenticationHelpers
end

def self.api_available?
@@api_available ||= ::Rails::Engine.subclasses.map(&:instance).map{ |e| e.class.to_s }.include?('Spree::Api::Engine')
end

def self.backend_available?
@@backend_available ||= ::Rails::Engine.subclasses.map(&:instance).map{ |e| e.class.to_s }.include?('Spree::Backend::Engine')
end

def self.frontend_available?
@@frontend_available ||= Gem::Specification.find_all_by_name('spree_frontend').any?
end

def self.api_available?
@@api_available ||= ::Rails::Engine.subclasses.map(&:instance).map{ |e| e.class.to_s }.include?('Spree::Api::Engine')
end

def self.emails_available?
@@emails_available ||= ::Rails::Engine.subclasses.map(&:instance).map{ |e| e.class.to_s }.include?('Spree::Emails::Engine')
end

if backend_available?
paths["app/controllers"] << "lib/controllers/backend"
paths["app/views"] << "lib/views/backend"
Expand Down