Refactor the project files and code #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SourceLink and SPDX license expressions. Remove redundant .NET Standard package references. Use framework-specific ifdefs instead of custom ones. Embed the package's icon in the nupkg file.
And remove some more redundant properties from the project files.
Fix a typo and prevent a boxing case in Parse.RegexMatch. Optimize a LINQ query in Parse.Commented.
And include the snupkg files to the AppVeyor artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the project files by removing redundant properties and dependencies, and fixes some warnings raised by Resharper/Rider. Moreover it adds support for SPDX license expressions and SourceLink (you also have to publish the
.snupkgfiles).