Prepare for Iceberg Sync #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeiPatiakin
commented
Dec 18, 2024
| } | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub enum LakehouseSyncTarget { |
There was a problem hiding this comment.
Please share if you have a better name for this enum
SergeiPatiakin
commented
Dec 18, 2024
| @@ -56,6 +57,17 @@ pub(super) struct SyncCommitInfo { | |||
| new_tx: bool, | |||
| } | |||
|
|
|||
| #[derive(Clone, Debug)] | |||
| pub struct IcebergSyncTarget { | |||
| url: String, | |||
There was a problem hiding this comment.
This could have more fields in future
gruuya
approved these changes
Dec 18, 2024
src/frontend/flight/handler.rs
Outdated
Comment on lines
193
to
194
| return Err(SyncError::InvalidMessage { | ||
| reason: "Unknown table format".to_string(), |
There was a problem hiding this comment.
I think you might be able to match exactly on cmd.format() and avoid this part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR generalizes sync-related code from Delta-specific types towards a more abstract "sync target" type which can be Delta or Iceberg. We do not yet implement Iceberg sync functionality, that will be in a future PR.