Expose conditional puts in the FileIO interface #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeiPatiakin
changed the title
SergeiPatiakin
commented
Dec 4, 2024
| @@ -344,6 +344,16 @@ impl OutputFile { | |||
| writer.close().await | |||
| } | |||
|
|
|||
| /// Create a new output file with given bytes. | |||
| /// Error out if the file already exists | |||
| pub async fn write_exclusive(&self, bs: Bytes) -> crate::Result<()> { | |||
There was a problem hiding this comment.
Naming suggestions for this method are welcome. I named it write_exclusive after O_EXCL in the Linux/Unix API which has equivalent functionality
There was a problem hiding this comment.
Sounds good. Might be useful if OutputFile::op was exposed upstream eventually, then we'd be able to do the same without the custom change.
There was a problem hiding this comment.
Good point. Maybe I could simplify this PR to just add a getter for OutputFile::op. That could be easier to get merged upstream.
gruuya
approved these changes
Dec 4, 2024
| @@ -344,6 +344,16 @@ impl OutputFile { | |||
| writer.close().await | |||
| } | |||
|
|
|||
| /// Create a new output file with given bytes. | |||
| /// Error out if the file already exists | |||
| pub async fn write_exclusive(&self, bs: Bytes) -> crate::Result<()> { | |||
There was a problem hiding this comment.
Sounds good. Might be useful if OutputFile::op was exposed upstream eventually, then we'd be able to do the same without the custom change.
SergeiPatiakin
force-pushed
the
write-exclusive
branch
from
e66ef22 to
9eaff9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileIo changes to support splitgraph/lakehouse-loader#12