DB-12364: update zookeeper property if a core system table index is recreated #5693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins please test branch @cdh6.3.0 |
|
jenkins please test branch @cdh6.3.0 |
ipraznik-splice
approved these changes
Jul 20, 2021
| @@ -81,7 +81,7 @@ public SpliceCatalogUpgradeScripts(SpliceDataDictionary sdd, TransactionControll | |||
|
|
|||
| scripts = new ArrayList<>(); | |||
| addUpgradeScript(baseVersion4, 2020, new UpgradeAddConglomerateNumberIndex(sdd, tc)); | |||
| addUpgradeScript(baseVersion4, 2024, new UpgradeScriptToPrioritizeSchemaIdInSystemIndices(sdd, tc)); | |||
| addUpgradeScript(baseVersion4, 2024, new UpgradeScriptToPrioritizeSchemaIdInSystemIndices(sdd, tc, startParams)); | |||
| // DB-11296: UpgradeConglomerateTable has to be executed first, because it adds a system table | |||
There was a problem hiding this comment.
my question is if should the version be changed to 2025 in this case? The migration was done for the previous build 2024, but fixed in 2025.
There was a problem hiding this comment.
It should still be 2024 in theory, because the index were changed since 2024, but we should recommend customer install 2025 build to trigger upgrade.
martinrupp
approved these changes
Jul 20, 2021
|
jenkins please test branch @cdh6.3.0 |
|
jenkins please test branch @cdh6.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short Description
Fixes a regression from DB-12224
Long Description
DB-12224 introduced an upgrade scripts that recreate some system table indexes. For core system tables and indexes, splice stores their conglomerate number in zookeeper. The upgrade scripts needs to update them.
How to test
Deploy a pre-2024 build to create a splice database. Deploy 2025 build to upgrade database. Restart and run simple queries, such as show tables, select count(*) from sys.systable, from sqlshell.