Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added triplet interactions: ring-exchange and spin-chirality coupling #462

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

added triplet interactions: ring-exchange and spin-chirality coupling #462

wants to merge 3 commits into from

Conversation

SpiritSuperUser
Copy link
Collaborator

No description provided.

@coveralls
Copy link

coveralls commented Oct 26, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 79.821% when pulling 263a7ec on SpiritSuperUser:triplet into b5351e5 on spirit-code:develop.

@codecov
Copy link

codecov bot commented Oct 26, 2018 •
edited
Loading

Codecov Report

Merging #462 (263a7ec) into develop (b5351e5) will decrease coverage by 0.72%.
The diff coverage is 8.96%.

@@             Coverage Diff             @@
##           develop     #462      +/-   ##
===========================================
- Coverage    48.04%   47.31%   -0.73%     
===========================================
  Files           72       72              
  Lines        11242    11450     +208     
===========================================
+ Hits          5401     5418      +17     
- Misses        5841     6032     +191

GPMueller
GPMueller requested changes Nov 5, 2018
View reviewed changes
Copy link
Member

@GPMueller GPMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CUDA version of the Heisenberg Hamiltonian is missing the corresponding changes.
A unit test would be good, just to make sure the code at least does not crash.
Also, indentation should be checked to be spaces.

core/include/engine/Hamiltonian_Heisenberg.hpp Outdated Show resolved Hide resolved
@GPMueller GPMueller force-pushed the develop branch 3 times, most recently from 0a4cc38 to c5dda64 Compare January 14, 2019 09:42
@GPMueller GPMueller force-pushed the develop branch 2 times, most recently from d06f4af to 218b5f5 Compare March 22, 2019 13:40
@GPMueller GPMueller force-pushed the develop branch 3 times, most recently from a056662 to 02dbca6 Compare April 5, 2019 13:15
@SpiritSuperUser SpiritSuperUser mentioned this pull request May 7, 2019
Closed
@GPMueller GPMueller force-pushed the develop branch 2 times, most recently from 5a61c3e to e2ac088 Compare June 4, 2019 15:42
@GPMueller GPMueller force-pushed the develop branch 3 times, most recently from 0ad5b3c to 6d1996b Compare June 12, 2019 21:29
@GPMueller GPMueller force-pushed the develop branch 8 times, most recently from d8f00a2 to 9532235 Compare June 23, 2019 18:32
@GPMueller
Copy link
Member

I updated this PR to the current develop version. @SpiritSuperUser could you please check whether your feature still works as intended?

Note, unit tests should still be implemented in order to avoid accidentally breaking it and providing a broken feature.

@GPMueller GPMueller requested a review from MSallermann May 30, 2021 18:23
@GPMueller GPMueller force-pushed the develop branch 2 times, most recently from 212372f to f49c114 Compare April 25, 2022 22:01
@muellan muellan force-pushed the develop branch 9 times, most recently from 63fbd74 to 2edff73 Compare June 7, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GPMueller GPMueller GPMueller requested changes

@MSallermann MSallermann Awaiting requested review from MSallermann

Assignees
No one assigned
Labels
core feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SpiritSuperUser @coveralls @GPMueller