Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binary Boolean VTable #1407

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Binary Boolean VTable #1407

merged 4 commits into from
Nov 20, 2024

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Nov 20, 2024 •
edited
Loading

  • Also merged all binary boolean functions since they're trivial to implement if you implement one of them.
  • And switched over to similar semantics as CompareFn where an encoding gets to see the arguments before deciding if they're supported.

FLUP: we weren't short-circuiting boolean operations if one of the sides was constant.

@gatesn gatesn enabled auto-merge (squash) November 20, 2024 21:29
lwwmanning
lwwmanning reviewed Nov 20, 2024
View reviewed changes
vortex-array/src/compute/boolean.rs Outdated Show resolved Hide resolved
vortex-array/src/array/bool/compute/mod.rs Show resolved Hide resolved
vortex-array/src/compute/mod.rs Outdated Show resolved Hide resolved
vortex-array/src/data/mod.rs Show resolved Hide resolved
danking
danking previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Member

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I look forward to the downfall of with_dyn.

vortex-array/src/array/constant/compute/mod.rs Show resolved Hide resolved
vortex-array/src/array/constant/compute/mod.rs Show resolved Hide resolved
a10y
a10y approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@a10y a10y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a bit weird to have a "vtable" that requires executing the function to figure out the mapping, but I don't have a better solution rn

@gatesn
Copy link
Contributor Author

gatesn commented Nov 20, 2024

it is a bit weird to have a "vtable" that requires executing the function to figure out the mapping, but I don't have a better solution rn

I think #1409 might be a better fix?

@gatesn gatesn requested a review from danking November 20, 2024 22:30
@gatesn gatesn merged commit dddf5f2 into develop Nov 20, 2024
14 checks passed
@gatesn gatesn deleted the ngates/binary-bool branch November 20, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwwmanning lwwmanning lwwmanning left review comments

@robert3005 robert3005 robert3005 approved these changes

@a10y a10y a10y approved these changes

@danking danking Awaiting requested review from danking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gatesn @danking @a10y @robert3005 @lwwmanning