Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with always computing is_constant #1411

Open
gatesn opened this issue Nov 20, 2024 · 0 comments
Open

Experiment with always computing is_constant #1411

gatesn opened this issue Nov 20, 2024 · 0 comments

Comments

@gatesn
Copy link
Contributor

gatesn commented Nov 20, 2024

We optimize for this fast-path so much, that it's probably worth computing is_constant with a short-circuiting statistics accumulator, i.e. bail as soon as we know it to be false.

We can then change ArrayData::is_constant and ArrayData::as_constant to always compute.

We may well want to lazily proxy ArrayView stats through a mutable object, although worth checking the cache hits on this one since ArrayView children are always constructed every time they are accessed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant