Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid nnunetv2=={2.4.0,2.4.1} to mitigate upstream bug for predict_single_npy_array #4448

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

joshuacwnewton
Copy link
Member

@joshuacwnewton joshuacwnewton commented Apr 19, 2024

Description

I've opened an upstream PR to fix this issue here: MIC-DKFZ/nnUNet#2114

I'm hoping that this will be merged for nnunetv2==2.4.2, hence avoiding only 2.4.0/2.4.1.

Linked issues

Fixes #4444.

@joshuacwnewton joshuacwnewton added bug category: fixes an error in the code upstream Issue caused by software dependencies sct_deepseg context: Global entry point for all deep learning segmentation methods labels Apr 19, 2024
@joshuacwnewton joshuacwnewton added this to the 6.3 milestone Apr 19, 2024
@joshuacwnewton joshuacwnewton requested a review from mguaypaq April 19, 2024 16:29
@joshuacwnewton joshuacwnewton self-assigned this Apr 19, 2024
requirements.txt Outdated Show resolved Hide resolved
Hopefully, my upstream fix will be merged for 2.4.2.
@joshuacwnewton joshuacwnewton changed the title Avoid nnunetv2==2.4.* to mitigate upstream bug for predict_single_npy_array Avoid nnunetv2=={2.4.0,2.4.1} to mitigate upstream bug for predict_single_npy_array Apr 19, 2024
Copy link
Member

@mguaypaq mguaypaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the investigation and the proposed fix upstream!

@joshuacwnewton joshuacwnewton merged commit fef1bea into master Apr 19, 2024
20 checks passed
@joshuacwnewton joshuacwnewton deleted the jn/4444-pin-nnunetv2-to-avoid-buggy-versions branch April 19, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug category: fixes an error in the code sct_deepseg context: Global entry point for all deep learning segmentation methods upstream Issue caused by software dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValueError: not enough values to unpack from nnunetv2 on master
2 participants