-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gis objects cleaning #181
base: dev
Are you sure you want to change the base?
Gis objects cleaning #181
Changes from 4 commits
c5cba2d
d296445
ce80c1c
5e068e4
fd7874e
46fc465
3ced984
4548684
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
using Speckle.Sdk.Models; | ||
|
||
namespace Speckle.Objects.Data; | ||
|
||
/// <summary> | ||
/// Represents an Autodesk.Revit.DB.Element object in Revit | ||
/// </summary> | ||
[SpeckleType("Objects.Data.GisObject")] | ||
public class GisObject : Base, IGisObject | ||
{ | ||
public required string name { get; set; } | ||
public required string type { get; set; } | ||
public required IReadOnlyList<Base> displayValue { get; set; } | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
using Speckle.Sdk.Models; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if we need this extra class - you could use the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it would be hard to enforce required properties, without which GisLayers don't make sense There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is CRS required for data extraction? it seems like it's only used on send, not receive There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, for GIS data, the data must have the georeference |
||
using Speckle.Sdk.Models.Collections; | ||
|
||
namespace Speckle.Objects.GIS; | ||
|
||
[SpeckleType("Objects.GIS.GisLayer")] | ||
public class GisLayer : Collection | ||
{ | ||
public required CRS crs { get; set; } | ||
public required string units { get; set; } | ||
public required string type { get; set; } | ||
} |
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
using Speckle.Sdk.Models; | ||
|
||
namespace Speckle.Objects.Geometry; | ||
|
||
[SpeckleType("Objects.Geometry.Polygon")] | ||
public class Polygon : Base | ||
{ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's add a required keyword to the boundary, and reconsider the proeprty names based off of other apps that may use polygons |
||
public string units { get; set; } | ||
public ICurve boundary { get; set; } | ||
public List<ICurve> voids { get; set; } | ||
|
||
public Polygon() | ||
{ | ||
voids = new List<ICurve>(); | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment should be updated - I will add this class in another pr, so no need to fix