Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair presentation build missing bib file #31

Merged
merged 2 commits into from
Jan 5, 2025

Conversation

georgiy-belyanin
Copy link
Contributor

@georgiy-belyanin georgiy-belyanin commented Jan 5, 2025

This is a patchset for fixing presentation build problems that occur after closing #30.

The first patch fixes building presentation template after 2ee060a
('fix: re-build pdf on updating non-main TeX files').

The problem appeared due to %.pdf %.bib prerequisite. It has been
missing for talk.pdf. Now %.pdf files simply use *.bib files as
prerequisites.

The second patch makes CI run LaTeX build not only on pushes but on pull
requests too to avoid such problems.

This patch fixes building presentation template after 2ee060a
('fix: re-build pdf on updating non-main TeX files').

The problem appeared due to `%.pdf` `%.bib` prerequisite. It has been
missing for `talk.pdf`. Now `%.pdf` files simply use `*.bib` files as
prerequisites.
This patch makes CI run LaTeX build not only on pushes but on pull
requests too. It can be useful since now two distinct pdf files are
build. E.g. 2ee060a ('fix: re-build pdf on updating non-main TeX files')
broke building the presentation. CI checks would prevent it.

The inspiration came to me when I broke master CI after
matmex-diploma-template#30.
@Kakadu Kakadu merged commit fdbc3a9 into spbu-se:master Jan 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants