Use stream_socket_client() exception for better message

spatie · Sep 28, 2023 · e60e30f · e60e30f
1 parent 652fb25
commit e60e30f
Showing 1 changed file with 14 additions and 8 deletions.
diff --git a/src/Downloader.php b/src/Downloader.php
@@ -180,14 +180,20 @@ protected function fetchCertificates(string $hostName): array
             $connectTo = $hostName;
         }
 
-        $client = @stream_socket_client(
-            "ssl://{$connectTo}:{$this->port}",
-            $errorNumber,
-            $errorDescription,
-            $this->timeout,
-            STREAM_CLIENT_CONNECT,
-            $streamContext
-        );
+        try {
+            $client = stream_socket_client(
+                "ssl://{$connectTo}:{$this->port}",
+                $errorNumber,
+                $errorDescription,
+                $this->timeout,
+                STREAM_CLIENT_CONNECT,
+                $streamContext
+            );
+        }
+        catch (\ErrorException $ex) {
+            $client = null;
+            $errorDescription = trim(str_replace('stream_socket_client():', '', $ex->getMessage()));
+        }
 
         if (! empty($errorDescription)) {
             throw $this->buildFailureException($connectTo, $errorDescription);