fix: support string and object for token.htmlStyle
#28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barbapapazes
changed the title
token.htmlStyle
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋,
I discover that the property
htmlStylecan be astringor anobject. I don't know why so I ask to Anthony Fu: https://x.com/soubiran_/status/1853757167087628345The answer:
The
objectsyntax is now the recommended way andstringsyntax is legacy and will be removed in the next major version. For now, we need to support both.see https://x.com/antfu7/status/1853759093321908615
I will investigate to try to understand because in this package, it is always astringbut in the https://github.com/spatie/commonmark-shiki-highlighter package, it is anobject.I suspect the version of Shiki is related to this.